Skip to content

Consolidate time series downsampling docs #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Sep 24, 2025
Merged

Consolidate time series downsampling docs #2274

merged 33 commits into from
Sep 24, 2025

Conversation

marciw
Copy link
Contributor

@marciw marciw commented Jul 24, 2025 •
edited
Loading

This PR restructures and partially revises the downsampling section:

  • remove repetitive info and filler
  • apply a more logical structure
  • consolidate methods on one page with tabs
  • edit for clarity, conciseness, and Elastic style (partial)

closes #2239

TODO: Create issue for "fast follow" improvements, in the interest of time

@marciw marciw linked an issue Jul 24, 2025 that may be closed by this pull request
Consolidate and restructure downsampling section #2239
Closed
8 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2025 •
edited
Loading

🔍 Preview links for changed docs

@marciw

This comment was marked as outdated.

Sign in to view
@marciw marciw marked this pull request as ready for review August 27, 2025 19:03
@marciw marciw requested review from a team as code owners August 27, 2025 19:03
@marciw marciw requested a review from yannis-roussos August 27, 2025 19:06
@marciw

This comment was marked as outdated.

Sign in to view
yannis-roussos
yannis-roussos reviewed Sep 5, 2025
View reviewed changes
yannis-roussos
yannis-roussos reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

@yannis-roussos yannis-roussos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @marciw, this revamp looks really great! I have added some small comments and pinged Mary to help with an additional review / pair of eyes - her expertise on downsampling will be invaluable to iron out the last few details and move forward!

marciw and others added 2 commits September 8, 2025 21:02
@marciw @yannis-roussos
Apply suggestions from review
0dc96f9 
Co-authored-by: Yannis Roussos <[email protected]>
@marciw @yannis-roussos
Apply suggestions from review
4a09927 
Co-authored-by: Yannis Roussos <[email protected]>
@marciw

This comment was marked as outdated.

Sign in to view
gmarouli

This comment was marked as outdated.

Sign in to view

@marciw
Copy link
Contributor Author

marciw commented Sep 15, 2025 •
edited
Loading

@yannis-roussos @gmarouli I've addressed most of your comments and asked for clarification on a few others. Please take another look when you have time. 🙏

Also note that this is just one piece of the overall restructuring -- additional PRs coming soon

@marciw
Copy link
Contributor Author

marciw commented Sep 15, 2025

for easy access, here's the link to the preview page -- you can start here and use the "next" link at the bottom of each page https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/2274/manage-data/data-store/data-streams/downsampling-time-series-data-stream

gmarouli
gmarouli approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @marciw , I added some small comments but I am very happy with how it looks, thank you!

yannis-roussos
yannis-roussos approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@yannis-roussos yannis-roussos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @marciw, looks great! I agree with Mary that this looks ready for prime time!

kilfoyle
kilfoyle reviewed Sep 16, 2025
View reviewed changes
kilfoyle
kilfoyle approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢
This looks great @marciw!

leemthompo
leemthompo approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like SMEs are happy, changes LGTM 👍.

I just wonder if we should pay attention to the H1s and add additional context 🤷.

For example, should we have stuff like :

- Downsampling concepts
+ How downsampling in {{es}} works

@marciw
Copy link
Contributor Author

marciw commented Sep 24, 2025

I just wonder if we should pay attention to the H1s and add additional context 🤷.

🙏 yes! coming soon in a follow-up PR (I did these in phases and I think that ended up being confusing)

@marciw marciw merged commit d7d846e into main Sep 24, 2025
7 checks passed
@marciw marciw deleted the mw-tsds-downsampling branch September 24, 2025 17:40
@marciw marciw mentioned this pull request Oct 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmarouli gmarouli gmarouli approved these changes

@yannis-roussos yannis-roussos yannis-roussos approved these changes

@leemthompo leemthompo leemthompo approved these changes

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consolidate and restructure downsampling section

5 participants

@marciw @gmarouli @leemthompo @kilfoyle @yannis-roussos